fix: Add audit logging for entity delete operations#31
Merged
Conversation
Previously, EntityValueBase only logged CREATE and UPDATE operations to the EntityAuditLog. DELETE operations were not logged, creating a compliance and security gap. Changes: - Added handleAuditLogDelete() method to log field values being deleted - Modified delete() to call handleAuditLogDelete() after successful delete - Delete audit logs show oldValueText (deleted value) with null newValueText The delete audit log behavior: - Logs all fields that have enable-audit-log="true" or "update" - Records the deleted value in oldValueText - Sets newValueText to null to indicate deletion - Includes changedByUserId, changedDate, and artifactStack Fixes #9 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Added audit logging for DELETE operations to close a compliance and security gap. Previously, only CREATE and UPDATE operations were logged.
The Problem
When
enable-audit-logwas set totrueon an entity or field:This meant deleted records left no trace in the audit trail.
The Solution
Added a new
handleAuditLogDelete()method that:enable-audit-log="true"or"update"oldValueText= the value being deletednewValueText= null (indicating deletion)Modified
delete()to call this method after successful deletion.Audit Log Record Example
Upstream Reference
Test Plan
enable-audit-log="true"fieldsFixes #9
🤖 Generated with Claude Code